Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of Lease page with storybook components and tailwind style #57

Open
tedovn opened this issue Jun 5, 2024 · 13 comments
Open
Assignees

Comments

@tedovn
Copy link
Contributor

tedovn commented Jun 5, 2024

No description provided.

@tedovn tedovn self-assigned this Jun 5, 2024
@tedovn tedovn changed the title Improvements of Dashboard page with storybook components Improvements of Lease page with storybook components and tailwind style Jun 5, 2024
@kostovster
Copy link
Member

The default value color in "Interest Due" should be white and only change color under specific circumstances. Please ping Alex to provide the logic.

Image

@kostovster
Copy link
Member

The "Opened On" field should be a non-changing date in the following format: MMM DD, YYYY (e.g., FEB 28, 2024)

Image

@kostovster
Copy link
Member

Both PnL and current token price need further styling for dark mode. The price needs to be styled as outlined in the design: token icon, 16px Garet Medium font, which reduces to 12px for all symbols after the decimal point

Image

@kostovster
Copy link
Member

Upon hovering over the line chart, the popup with historical time and price data is redundant. The behavior in this scenario should be as follows:

Upon hovering over the line chart, the token price in the upper right corner must change based on the historical point that is selected.

@kostovster
Copy link
Member

Upon lease repayment, closure, or token collection, all buttons should be in a disabled state, meaning no other operation can be performed until the current one is finished.

The spinner should be visible on the last operation that the user selected. In dark mode, the disabled state for buttons should have the following styles: fill #142237, stroke #2B384B, text color #5E7699

Image

@pKarlovska
Copy link

pKarlovska commented Jun 11, 2024

PnL (Profit & Loss) indicator does not toggle between USD and percentage

The PnL (Profit & Loss) indicator only switches to displaying the profit and loss amount in USD when the position is in profit. It does not toggle to showing the percentage of the total in the case of a loss.

Image

@pKarlovska
Copy link

Incorrect Formatting of the Amount $X.xxxx

The amount should be presented on a single line, with the decimal numbers appearing on the same line as the main part of the number.

Image

@pKarlovska
Copy link

Missing chart on mobile device and incorrect display of "Opened on" text and Health indicator

  1. The chart is missing on the mobile device, leading to an incorrect representation of data.
  2. The "Opened on" text and Health indicator are displayed incorrectly. They are not properly aligned and centered as per the design.

Image

Image

@pKarlovska
Copy link

Upon closing a lease:

  1. The "Relay" button should be disabled.
  2. "Debt" and "Due" should have a skeleton loader.

For reference screenshot from production

Image

Image

@kostovster
Copy link
Member

When Pnl is clicked it should toggle between the dollar value and percentage

Image

@pKarlovska
Copy link

pKarlovska commented Jun 12, 2024

Interest rate is not displayed as strike out

Example: BUY POSITION #aspgtzfd
The interest rate for the current position is not being displayed correctly as strikethrough, during the DeFi Summer promotion.

Image

@tedovn
Copy link
Contributor Author

tedovn commented Jun 15, 2024

Interest rate is not displayed as strike out

Example: BUY POSITION #aspgtzfd The interest rate for the current position is not being displayed correctly as strikethrough, during the DeFi Summer promotion.

Image

@alexandermake

@tedovn
Copy link
Contributor Author

tedovn commented Jun 15, 2024

Upon hovering over the line chart, the popup with historical time and price data is redundant. The behavior in this scenario should be as follows:

Upon hovering over the line chart, the token price in the upper right corner must change based on the historical point that is selected.

@alexandermake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants