Confusing error message when using import inside CJS file
#56518
Labels
esm
Issues and PRs related to the ECMAScript Modules implementation.
Comments
marco-ippolito
added
the
esm
wongprom
added a commit
to wongprom/node
that referenced
this issue
Jan 15, 2025
- Added new tests for invalid imports in .cjs files. - Added tests for loading .mjs files in CommonJS packages. - Refactored assertions to align with project lint rules. - Verified all tests pass with Node.js tools and addressed related errors. - Formatted src/node_contextify.cc using clang-format for consistent code style. Refs: nodejs#56518
wongprom
added a commit
to wongprom/node
that referenced
this issue
Jan 15, 2025
- Updated `GetWarningMessage` in `node_contextify.cc` to handle `.cjs` files and emit appropriate warnings. - Normalized the warning message in tests to simplify comparison and improve readability. - Added specific tests to verify warnings for invalid imports in `.cjs` files and handling of `.mjs` in CommonJS packages. Note: The test currently compares the exact string value for warnings. This could be optimized by validating only the critical parts of the warning message. Refs: nodejs#56518
wongprom
added a commit
to wongprom/node
that referenced
this issue
Jan 15, 2025
- Added new tests for invalid imports in .cjs files. - Added tests for loading .mjs files in CommonJS packages. - Refactored assertions to align with project lint rules. - Verified all tests pass with Node.js tools and addressed related errors. - Formatted src/node_contextify.cc using clang-format for consistent code style. Refs: nodejs#56518
wongprom
added a commit
to wongprom/node
that referenced
this issue
Jan 15, 2025
- Updated `GetWarningMessage` in `node_contextify.cc` to handle `.cjs` files and emit appropriate warnings. - Normalized the warning message in tests to simplify comparison and improve readability. - Added specific tests to verify warnings for invalid imports in `.cjs` files and handling of `.mjs` in CommonJS packages. Note: The test currently compares the exact string value for warnings. This could be optimized by validating only the critical parts of the warning message. Refs: nodejs#56518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
23.6.0
Platform
Subsystem
esm
What steps will reproduce the bug?
file.cjsfile containingimport "path";node file.cjsHow often does it reproduce? Is there a required condition?
/
What is the expected behavior? Why is that the expected behavior?
It should tell me that to use
importinside file I need to use.mjsand not.cjsWhat do you see instead?
It also offers the solution of setting "type": "module" in the package.json, but that is wrong since my file is .cjs.
Additional information
No response
The text was updated successfully, but these errors were encountered: