From 7b60bcb2f0319e2802c83edd0cdcf5d4fd0927ee Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Sat, 11 Jan 2025 13:17:54 -0800
Subject: [PATCH] quic: fixup errant LocalVector usage
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/56564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
---
 src/quic/session.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/quic/session.cc b/src/quic/session.cc
index d939edee18e01a..608899a59f3cb7 100644
--- a/src/quic/session.cc
+++ b/src/quic/session.cc
@@ -2728,7 +2728,7 @@ void Session::EmitVersionNegotiation(const ngtcp2_pkt_hd& hd,
 
   LocalVector<Value> versions(env()->isolate(), nsv);
   for (size_t n = 0; n < nsv; n++) {
-    versions.push_back(Integer::NewFromUnsigned(env()->isolate(), sv[n]));
+    versions[n] = Integer::NewFromUnsigned(env()->isolate(), sv[n]);
   }
 
   // supported are the versions we acutually support expressed as a range.