-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for "build metadata"? #511
Comments
So instead of adding a |
REEDITED FOR CLARITY:
The bolded section is just about exactly what we are looking for from the semver docs... but the backend of jitsu e.g. nodejitsu would need to do something useful with it and jitsu would pass it through with Here's one of the possible examples to think about: Sample project {
"name": "Project",
"description": "Projection description",
"version": "0.0.0",
"main": "index",
"licenses": [
{
"type": "GPL-3.0+",
"url": "http://www.gnu.org/copyleft/gpl.html"
}
],
"subdomain": "somedomain",
"domains": [
"somedomain.org"
],
"scripts": {
"start": "node index.js"
},
"engines": {
"node": ">=0.10.33"
}
}
We do a shell script along with a fictitious switch as of right now of: #!/bin/bash
# Pretend this next line returns `12abc67`
HEAD=`git rev-parse --short HEAD`
# This next line would return `0.0.0`
VER=`node -p 'JSON.parse(process.argv[1]).version' "$(cat package.json)"`
# The `-r` switch could validate numeric.numeric.numeric
# The `-b` switch could validate ASCII alphanumerics and hyphen [0-9A-Za-z-],
# with the period `.` which can optionally mean whatever in the backend of Nodejitsu
jitsu deploy -c -r $VER -b $HEAD Nodejitsu creates the snapshot with this {
"name": "Project",
"description": "Projection description",
"version": "0.0.0-1+12abc67",
"main": "index",
"licenses": [
{
"type": "GPL-3.0+",
"url": "http://www.gnu.org/copyleft/gpl.html"
}
],
"subdomain": "somedomain",
"domains": [
"somedomain.org"
],
"scripts": {
"start": "node index.js"
},
"engines": {
"node": ">=0.10.33"
}
} All of this could keep semver happy, nodejitsu and quite possibly more than just one customer too. |
Do my huge, multiple, revisions above make more sense? |
bump Any progress of restoring the build metadata (e.g. everything including and after the |
Apparently semver (item 10) does have a standard for build metadata... this could be quite useful to nodejitsu and your customers if it was supported in this package. TIA
The text was updated successfully, but these errors were encountered: