Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeTest, afterTest need longer timeouts #20

Open
pacovell opened this issue Jul 7, 2011 · 2 comments
Open

beforeTest, afterTest need longer timeouts #20

pacovell opened this issue Jul 7, 2011 · 2 comments

Comments

@pacovell
Copy link

pacovell commented Jul 7, 2011

Both beforeTest and afterTest may be doing more expensive setup/takedown that need a longer time to run. For example, to set up a selenium browser session (via soda), takes around 4 seconds on my computer.

I could put this in a "Background:" step and then use cucumis -t, but (a) sometimes it can take longer, and go past even the default 5s timeout of the async step (requiring a 'regular' custom command line or creating a script) and (b) I don't want a new session for each feature, as this unnecessarily slows down the testing.

The most crude solution is to simply increase the timeout on cucumis.js from 100ms to 10000ms in these cases. After all, if you actually have to kill a step for taking too long, this is a testing error and probably needs attention. I can imagine a more elegant solution where you can specify a timeout. Ideally this would be programmatic to avoid custom command lines.

I'm happy to write something along these lines and submit if this is the desired solution, or we can just increase the timeout. Thoughts?

@tomilaine
Copy link

I'm having the exact same issue.

@tomilaine
Copy link

This doesn't seem to raise much discussion. I made a pull request to use the timeout-variable configurable with cucumis -t, to be used also in regarding these events. That solves this issue at least for me. #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants