Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should overwrite option in prep_conversion regenerate .heudiconv stored files #807

Open
1 of 2 tasks
alexpron opened this issue Dec 4, 2024 · 3 comments
Open
1 of 2 tasks

Comments

@alexpron
Copy link

alexpron commented Dec 4, 2024

Summary

Dear heudiconv experts,

I have kind of a specific use case:

  • I have DICOM data that are downloaded in a temporary directory located inside a subdirectory of the a main directory
    where the BIDS conversion is performed with heudiconv and stored as a datalad dataset.
  • The final datalad dataset may be copied or moved but data can still be added.
  • By default I activated the overwrite option as I wanted the update of the data to be handled by datalad.
  • With overwrite and after moving the dataset the conversion on already converted data crashes as edit.txt and heuristic file are identical but filegroup.json contains absolute path that are non longer valid

Hence, should the overwrite option also triggers the full generation of new data including BIDS mapping ?
Or am I doing it the wrong way and should I catch the exceptions before,

Best,
Alexandre

Platform details:

Choose one:

  • Local environment
 - OS: Fedora 
 - Python 3.10. 13 (conda virtual environement)
  • Container
  • Heudiconv version:
1.1.6
@yarikoptic
Copy link
Member

I guess there is somewhat two issues

@yarikoptic
Copy link
Member

also related

but there I am not sure we could avoid storing full paths since temporary from extracted from zipball dicoms.

@alexpron
Copy link
Author

alexpron commented Dec 5, 2024

Thanks @yarikoptic for your detailed answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants