Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI generate test to use branch from ENV variable #157

Open
bterone opened this issue Feb 20, 2023 · 0 comments
Open

Update CLI generate test to use branch from ENV variable #157

bterone opened this issue Feb 20, 2023 · 0 comments
Milestone

Comments

@bterone
Copy link
Collaborator

bterone commented Feb 20, 2023

Why

Currently, we've done a quick fix to ensure that the CI passes on every branch, however, that is not a long-term solution.

Previously the issue was that the vite template would be downloaded from the repository, however we needed to specify a branch name or a commit hash that contained the vite template folder.

A longer-term solution would be to fetch the current branch, pass that as an environment variable so the test can use that as the viteTemplateReference and pull the vite template from there.

Who Benefits?

Everyone including future contributors to the vite template package 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant