Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery IDeferred out of date #378

Open
michaelaird opened this issue Jun 11, 2013 · 2 comments
Open

jQuery IDeferred out of date #378

michaelaird opened this issue Jun 11, 2013 · 2 comments

Comments

@michaelaird
Copy link
Contributor

I came across an issue today with methods on IDeferred that were deprecated in jQuery 1.7 and removed in jQuery 1.8:

  • IsResolved
  • IsRejected
  • Pipe (deprecated but not yet removed)

see http://api.jquery.com/category/deferred-object/

The interface in both the master and cc branches seems to be the pre 1.7 api.

I'm happy to contribute an updated interface but it raises the question of which version of jQuery should Script# support? jQuery seems to be iterating quite quickly lately and being aggressive about removing deprecated api's. Should we be versioning the library (and nuget package) for each version of jQuery?

Thoughts?

@nikhilk
Copy link
Owner

nikhilk commented Jun 11, 2013

We should definitely update the current assembly to at least v1.10.

Going forward, maybe look at a different strategy for the newer 2.x builds. I want to be able to say the jquery assembly and nuget versions should match up with jquery script versions, but it might not be practical to keep up with every change in jquery.

@michaelaird
Copy link
Contributor Author

My understanding is that 1.{current} and 2.{current} should have identical api's but 2.{current} has a bunch of code removed that was required to support older browsers.

I'll try to spend a bit of time over the next week updating the jQuery project to 1.10.1/2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants