Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a parsing error occurs during decode of an AK response, then the remaining parameters are not decoded and 0's are returned for their values #170

Open
labviewmantc opened this issue Apr 27, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@labviewmantc
Copy link

For the AK protocol, the add-on expects numbers (represented as strings) for each returned parameter, but, if there is an error converting the string to a number, all further processing of the response is stopped and 0's are returned for their values.

Suggestion: continue processing/parsing the remaining parameters. The final overall error code would be bit-mapped to indicate which parameter(s) has an error and use a base error-code of 0x80000 with bits 0 thru 15 to indicate which parameter(s) had the decode error. And the value for the parameter(s) that had the conversation error would return a globally user-defined value (for the driver) such as -999.999 so data being collected or displayed in Veristand can show the data is not available or in an error state).

@bogdanp-ni
Copy link
Contributor

Hello @labviewmantc,

Sorry for the delayed response, we'll take a look at this issue.

@PaulDanH PaulDanH added the enhancement New feature or request label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants