Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using og:image filenames from middleman's :asset_hash extension #6

Open
larsvegas opened this issue Feb 5, 2017 · 3 comments · May be fixed by #14
Open

Using og:image filenames from middleman's :asset_hash extension #6

larsvegas opened this issue Feb 5, 2017 · 3 comments · May be fixed by #14

Comments

@larsvegas
Copy link

Hey,

I'm using the middleman :asset_hash extension so assets will be renamed after build from myimage.jpg to something like myimage-f5d3f0c1.jpg.

How can I make middleman-ogp to substitute the og:image property with the correct one with the hash on build?

Thanks,
Lars
@tisba
Copy link

tisba commented Jun 2, 2020

I'd like to see if I can contribute this to middleman-ogp. Could you maybe point me in the right direction?

@tisba
Copy link

tisba commented Jun 2, 2020

-ping @ngs :)

@ngs
Copy link
Owner

ngs commented Jun 2, 2020 •
edited
Loading

This could be possible by converting value to contain asset hash.

https://github.com/ngs/middleman-ogp/blob/master/lib/middleman-ogp/extension.rb#L165

But not yet sure how to retrieve asset hash from path.

ngs added a commit that referenced this issue Jun 2, 2020
@ngs
Support asset hash
f958e55 
Fixes #6
@ngs ngs linked a pull request Jun 2, 2020 that will close this issue
Open
@ikuwow ikuwow mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support asset hash ngs/middleman-ogp
3 participants
@ngs @tisba @larsvegas