Should store.update be type safe?

[alastair-todd]

I really should not be able to do this right, where unknown is NOT declared on the withProps interface?

authStore.update((state) => ({
  ...state,
  user: { id: 'foo' },
  unknown: 'me'
}));

but I can!

[Roguyt]

Interested to know if you found an alternative or if @NetanelBasal as a recommendation on this ?

That's the only thing that bothers me a bit when using Elf in a team project.

[HyruleGG]

Yea I agree.... I will try to get a bit more into that but from a quick check, @NetanelBasal thought about that. Either a problem with the lang support in our IDE or something else...

U extends UpdateFn<getEntityType<S, Ref>>
export declare type UpdateFn<Entity> = Partial<Entity> | ((entity: Entity) => Entity);

[EricPoul]

I played with this lately. It seems to be a typescript problem. TS seems to only check all required properties and not pay attention to the unrelative to type ones if you haven't added an explicit return type. And when you add an explicit return type to the function declaration TS starts to check for full equality to the type.
You can look at the example here.

[strigefleur]

As of now there's setProp method with root properties type support. Though setProps version is prone to same problem as author describes. Still you can use multiple setProp in one update chain to achieve strict results.