-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborate with ng-metadata #138
Comments
@Hotell @MikeRyan52 basically we just want to polyfill Angular 2 as much as possible but currently we want to support ES6 and TypeScript (not just TypeScript). So that does limit us technically in some ways. Perhaps we should just go full TypeScript though if its holding us back too much. Considering ES6 isn't even really supported much by Angular 2 (it's either ES5 or TypeScript). |
Wow @Hotell, I'm reviewing ng-metadata and you have quite a lot implemented! You certainly seem to have implemented your polyfill more like how the actual ng2 codebase has done it and organized it in the same way with folders/modules. I'm not sure how you are going to feel about our codebase in that it follows a completely different structure. It's clear you've taken directly from Angular 2's codebase whenever possible, which is cool. We probably don't have the capacity to reorganize ng-forward to match the same structure :( I totally understand that you are probably very attached to your codebase and might find it difficult to let that go and work with us on ng-forward. I'd say at the least we'd love to learn from your codebase and see if we can implement some of the features you've already added (and you could do the same from us). Do you have any dead code? Like features that look like they are there but that aren't actually working (for example @self(), @SkipSelf() decorators)? I'm seeing things that you have in your code base but that we don't have are listed here. Let me know if any of these are not actually implemented:
Does this sound about right, am I missing anything? Any other gripes with ng-forward (don't worry you won't offend us :)? |
Hi guys, here are basic ideas behind ng-metadata:
|
@timkindberg thanks for kind words! First I've created my own logic for handling decorators and related stuff, but I've decided to look at ng2 codebase. What I saw, made perfect sense to me, so I've adopted their style of decorating classes which is very extensible. So I did complete rewrite by mirroring modularity to ng2 hehe. Dead code: yes it's there :)
DI decorators:
So what's left to be done in ng-metadata:
|
I've skimmed through your code base. Nah it isn't so bad :P, but the biggest pain point is that you want to support ES5 and ES6 as first class citizen. IMHO that doesn't make sense ( at least the ES5 version ). Using If we do this, then I see a way for |
Talked with @Hotell, list of things in ng-metadata that is missing from ng-forward:
//@Input
$scope.$watch($attrs.myFoo,(value)=>this.foo = value)
//@Output
$scope.$evalAsync($attrs.onFoo) |
@Hotell has written the ng-metadata project: https://github.com/ngParty/ng-metadata
The project serves the same overall purpose as ng-forward so it would be good to see how we can collaborate. This thread can serve as a place for transparent discussion.
First and foremost how do the two projects compare and contrast?
@MikeRyan52
The text was updated successfully, but these errors were encountered: