Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Relax requests dependency for python package #474

Open
kMutagene opened this issue Nov 7, 2024 · 4 comments
Open

[Feature Request] Relax requests dependency for python package #474

kMutagene opened this issue Nov 7, 2024 · 4 comments

Comments

@kMutagene
Copy link
Member

requests is such a widely used python package that the pinned dependency in this project leads to potential dependency conflicts.

i'd suggest relaxing it to be >= 2.28.1 && <3.0.0
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 7, 2024
@kMutagene
Copy link
Member Author

cc @HLWeil

@HLWeil
Copy link
Member

HLWeil commented Nov 18, 2024

Isn't this already the case?

ARCtrl/src/ARCtrl/ARCtrl.Python.fsproj

Line 69 in 30e5a19

<Package Name="requests" Version="&gt;= 2.28.1 &lt; 3.0.0" ResolutionStrategy="Max" />

@HLWeil
Copy link
Member

HLWeil commented Nov 18, 2024

Ah I see, it's in the pyproject.toml

@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Nov 18, 2024
@HLWeil HLWeil moved this to Ready in ARCStack Nov 18, 2024
@HLWeil HLWeil moved this from Ready to In progress in ARCStack Nov 18, 2024
@HLWeil HLWeil mentioned this issue Nov 18, 2024
Merged
@kMutagene
Copy link
Member Author

can this be closed via #476 @HLWeil ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ARCStack
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HLWeil @kMutagene