Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference panel accepts a csv #19

Merged
merged 14 commits into from
Mar 21, 2024
Merged

Conversation

eugeniafontecha
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR addresses this issue #11

@atrigila atrigila linked an issue Mar 20, 2024 that may be closed by this pull request
@atrigila atrigila added the enhancement New feature or request label Mar 20, 2024
@LouisLeNezet
Copy link
Collaborator

Sorry @eugeniafontecha this code is a duplicate of #18
For it to works we need to correctly manage the files by chromosome and use the meta map accordingly.
You effectively saw the different problem I've ran into.
Could you look at my PR ? it contains all the modification you've done.

@atrigila
Copy link
Collaborator

Hi @LouisLeNezet!

I understand your concerns regarding the duplication of code but I would like to provide additional context. The contribution from @eugeniafontecha, while overlapping with your work, represents a unique effort during the hackathon that I believe deserves consideration.

This is one of Eugenia's first contributions in Nextflow and she went above and beyond during her first hackathon. I think it would be nice, as members of the nf-core community, to welcome participation from less experienced contributors.

Since Eugenia's code contains partially the same modifications as yours, you could perhaps review Eugenia's PR and consider how her modifications can complement and improve upon your work. Then, if you accept her PR, you can sync your code with these changes and then submit your additional modifications accordingly. I think that this way we all benefit and foster a supportive community :)

@LouisLeNezet
Copy link
Collaborator

@atrigila I understand completely.
It will break a few things on my PR but I will manage.
Would it be possible for her to do the following command ?

nf-core subworkflows update vcf_impute_glimpse
nf-core subworkflows update vcf_phase_shapeit5

Copy link
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done ! Congrats on your first PR on this pipeline.
Looking forward to your next contributions. 😄

@LouisLeNezet
Copy link
Collaborator

We will merge even if the test fail as the #18 will fix it :)

@LouisLeNezet LouisLeNezet merged commit fd06eb8 into nf-core:dev Mar 21, 2024
2 of 4 checks passed
@eugeniafontecha
Copy link
Contributor Author

Thank you @LouisLeNezet and @atrigila !!

atrigila pushed a commit that referenced this pull request Mar 27, 2024
Reference panel accepts a csv
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference panel should accept a CSV
3 participants