-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference panel accepts a csv #19
Conversation
Sorry @eugeniafontecha this code is a duplicate of #18 |
Hi @LouisLeNezet! I understand your concerns regarding the duplication of code but I would like to provide additional context. The contribution from @eugeniafontecha, while overlapping with your work, represents a unique effort during the hackathon that I believe deserves consideration. This is one of Eugenia's first contributions in Nextflow and she went above and beyond during her first hackathon. I think it would be nice, as members of the nf-core community, to welcome participation from less experienced contributors. Since Eugenia's code contains partially the same modifications as yours, you could perhaps review Eugenia's PR and consider how her modifications can complement and improve upon your work. Then, if you accept her PR, you can sync your code with these changes and then submit your additional modifications accordingly. I think that this way we all benefit and foster a supportive community :) |
@atrigila I understand completely.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done ! Congrats on your first PR on this pipeline.
Looking forward to your next contributions. 😄
We will merge even if the test fail as the #18 will fix it :) |
Thank you @LouisLeNezet and @atrigila !! |
Reference panel accepts a csv
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).This PR addresses this issue #11