Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cities don't show weather related background imagein the Weather app #50

Open
e-alfred opened this issue Nov 6, 2017 · 4 comments

Comments

@e-alfred
Copy link
Collaborator

e-alfred commented Nov 6, 2017

Steps to reproduce

  1. Open Weather app and click on a city.

Expected behaviour

A background image that fits the weather should be shown (in this case "overcast clouds")

Actual behaviour

A black background shows up.

Server configuration

Operating system: Ubuntu 16.04

Web server: Apache 2.4

Database: Mysql 5.7

PHP version: 7.0

Nextcloud version: 12.0.3

Updated from an older Nextcloud/ownCloud or fresh install: Updated from Nextcloud 11

Where did you install Nextcloud from: Official updater

Client configuration

Browser: Palemoon 27, Vivaldi 1.12

Operating system: Debian 9

Logs

Browser log

Browser log
TypeError: $scope.loadApiKey is not a function
Stack trace:
@https://server/apps/weather/js/app.js?v=becea38df1d73519905bb88fac044cff-1:65:26
f/q<@https://server/owncloud/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:161:437
e@https://server/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:48:146
pg/k.defer/c<@https://server/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:51:68
 angular.min.js:123:209

TypeError: $scope.loadApiKey is not a function
Stack trace:
@https://server/apps/weather/js/app.js?v=becea38df1d73519905bb88fac044cff-1:65:26
f/q<@https://server/owncloud/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:161:437
e@https://server/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:48:146
pg/k.defer/c<@https://server/apps/weather/js/angular.min.js?v=becea38df1d73519905bb88fac044cff-1:51:68
 "Possibly unhandled rejection: {}"
@nerzhul
Copy link
Collaborator

nerzhul commented Nov 10, 2017

hello, thanks for your report.
the JS problem seems to be unrelated, and should be fixed. Do you mean background is black because "overcast clouds" is not handled ?

@e-alfred
Copy link
Collaborator Author

Yes, the background is black for "overcast clouds". I later saw the JS bug come up most of the time, so it is probably unrelated.

@maxolasersquad
Copy link

I am seeing the same thing.

image

@e-alfred
Copy link
Collaborator Author

I added more backgrounds in the latest releases, but some weather conditions might still not be covered. If you have some good pictures displaying weather conditions under a free license, please add them to the app with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants