Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ssl verification in development #988

Open
bdovaz opened this issue Nov 20, 2024 · 1 comment
Open

Disable ssl verification in development #988

bdovaz opened this issue Nov 20, 2024 · 1 comment
Labels
0. Needs triage enhancement New feature or request

Comments

@bdovaz
Copy link
Contributor

bdovaz commented Nov 20, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: (see administration page)

30.0.2

Is your feature request related to a problem? Please describe.

When we are developing there is no way to run Keycloak and Nextcloud over https with a self-signed certificate and have the user_oidc app work correctly. There are several scripts that make requests that do not take into account the ability to set the verify field of Guzzle:

Search for $client-> inside this scripts

https://github.com/nextcloud/user_oidc/blob/main/lib/Controller/LoginController.php
https://github.com/nextcloud/user_oidc/blob/main/lib/Service/DiscoveryService.php

Some of the work is already done because at least for certain errors it is taken into account that if Nextcloud is in debug mode it considers that it is safe:

private function isSecure(): bool {

Nextcloud does not have the option to globally disable verify by default, which would be ideal:

https://github.com/nextcloud/server/blob/d334773b9868561db86209bbf801d2835f182a7b/lib/private/Http/Client/Client.php#L55

Describe the solution you'd like

Assume that if Nextcloud is in debug mode it sends on Guzzle requests: $options['verify'] = false

Or have a setting in config.php itself as some apps do:

https://github.com/nextcloud/richdocuments/blob/05fa51e71a408a16624588d4f7aed23257090bb2/lib/Service/CachedRequestService.php#L95

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@bdovaz bdovaz added 0. Needs triage enhancement New feature or request labels Nov 20, 2024
@bdovaz
Copy link
Contributor Author

bdovaz commented Nov 26, 2024

@julien-nc I have waited a week, but seeing that there is no response to this issue.

Would you be willing to accept a PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant