-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make smart picker button more prominent #6818
Comments
@juliusknorr I added a quick sketch to the issue description. Did I get it right? My first intuition would be that this can be used to insert geometrical shapes. Maybe a ➕ would be more appropriate to indicate this adds something to the document. @nextcloud/designers What do you think? |
@marcoambrosini
Since the original discussion was to put it next to the assistant that would kind of imply it showing for the block the current cursor is on independent of mouse position and content. I tend to only show it for empty blocks - because that avoids conflicts with the preview menu that shows on blocks that contain only a link or a link preview. |
@max-nextcloud I think it should show
I think this is a bit different because the assistant currently targets the whole text with its actions (right?), whilst this smart picker would be a "position dependent" button, as it would insert a block in a specific location.
This is not a problem, I'd follow Notion and Anytype UX here, where the plus button sits just to the left of a context action menu, which also serves as an drag button if long pressed. |
@marcoambrosini I see where you are going and I agree with the overall direction. At the same time we want to ship something with this release and what you have in mind is more involved to implement. So now I focus on the fact that it should only be in the current line and used the I will first make sure i have somehting that works and could be merged and then tweak. I'll follow this list and see how far i get:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Current state is in the description of the PR. Let's move the discussion there. |
We have the smart picker button in the link menu but it is too hidden, so we should show it more prominent next to the assistant button (below as a tertiary button) in addition.
The text was updated successfully, but these errors were encountered: