Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab key doesn't work, no way to indent. #601

Closed
jvalrog opened this issue Jan 21, 2020 · 16 comments
Closed

Tab key doesn't work, no way to indent. #601

jvalrog opened this issue Jan 21, 2020 · 16 comments
Labels
1. to develop bug Something isn't working

Comments

@jvalrog
Copy link

jvalrog commented Jan 21, 2020

Describe the bug
Can't indent code snippets or paragraphs in Text app.

To Reproduce
Hit tab.

Expected behavior
Add a tab character to the current line.

Client details:

  • OS: Linux (Docker)
  • Browser: Firefox 72 and Chrome 79
  • Device: Desktop

Text app version: 2.0.0

Operating system: Ubuntu 18.04

Web server: Apache (from Docker official image)

Database: Sqlite3

PHP version: 7.3.13

Nextcloud version: 18.0.0 stable

@jvalrog jvalrog added the bug Something isn't working label Jan 21, 2020
@daCaPo
Copy link

daCaPo commented Jan 25, 2020

This probably would also improve compatibility with apps like iA Writer on iOS. Actually, NC Text and iA Writer treat lists with indentations differently:

  • NC Text uses 2 space characters for list intendation
  • iA can be configured to use spaces, but expects 4 spaces per intendation level

@juliusknorr
Copy link
Member

Can't indent code snippets or paragraphs in Text app.

Paragraph indentation is nothing that can be represented in markdown as trailing whitespace would just be removed. For code blocks we should fix this. 👍

This probably would also improve compatibility with apps like iA Writer on iOS. Actually, NC Text and iA Writer treat lists with indentations differently:
NC Text uses 2 space characters for list intendation
iA can be configured to use spaces, but expects 4 spaces per intendation level

This is a different topic, please open a separate issue to discuss something like this. In general I would like to have some more information on how other markdown editors handle this, as two spaces are definitely fine according to the commonmark standard.

@Fmstrat
Copy link

Fmstrat commented Jun 12, 2020

This is a problem with bullet points, too. You have to backspace to make the bullets on one line, press enter again, then hit tab.

@juliusknorr
Copy link
Member

This is a problem with bullet points, too. You have to backspace to make the bullets on one line, press enter again, then hit tab.

Please share some more detailed steps about that as I cannot see any issue with the tab indentation on lists:

Peek 2020-06-15 12-09

@Fmstrat
Copy link

Fmstrat commented Jun 15, 2020

@juliushaertl Ahh, good catch. I figured out the use case that was causing it. It was happening for me in every file because all of my files I was trying to change were formatted the same way.

Upload a file into Nextcloud of test.md:

This is a test with a blank line after it.

* Bullet 1
* Bullet 2
  • Now open the file in Nextcloud Text, and place your cursor at the T in "This".
  • Hit the ordered list button. You now have 3 bullets, however there is a "hidden" carriage return from the blank line that existed before
  • Place your cursor next to the B in "Bullet 1"
  • Press tab
  • Focus goes up the browser's menu bar

To fix it, you have to backspace from "Bullet 1" up to the previous line and press enter. This makes since because there is actually an empty line there, but Text (or the editor, rather) isn't giving any indication the blank line is there.

edit
Maybe this is a Prosemirror thing?

@juliusknorr
Copy link
Member

Maybe this is a Prosemirror thing?

Might be, could you check at https://tiptap.scrumpy.io/ if you can reproduce it there?

@Fmstrat
Copy link

Fmstrat commented Jun 15, 2020

Sure thing, and yes, to an extent. Since I can't start from raw MD I faked it by inserting a blank line and backspacing. You can see in the GIF. Process was:

  • Type "test"
  • Press enter twice
  • Type "test"
  • Ordered list button
  • Go to blank line between "test"s
  • Backspace
  • Ordered list button (now that invisible return from the line is still there but you can't see it)
  • Click on second line
  • Tab (jumps out of editor instead of indenting)

tabs

@PVince81
Copy link
Member

PVince81 commented Mar 1, 2022

is this something that needs to be implemented from scratch or is indenting supported by the underlying library and it's just a matter of calling the right function ? @juliushaertl

@mejo-
Copy link
Member

mejo- commented May 5, 2022

I just tested this on latest Text in Nextcloud 24 and the bug has been fixed by the list item improvements by @max-nextcloud 🎉

@Isac99
Copy link

Isac99 commented Jul 24, 2023

Looks like this bug is back in version 27.0.1 - just upgraded and the tab key no longer indents bullet points are unordered lists.

@mejo-
Copy link
Member

mejo- commented Jul 25, 2023

@Isac99 I cannot reproduce this myself. But someone else reported this as well in #4389. Could you reply to my questions over there?

@SmartLiving-Rocks
Copy link

SmartLiving-Rocks commented Sep 7, 2023

in version 27.0.1

In Version 27.0.2, too (Docker nextcloud:27.0.2-apache)

It is working in Collectives and Notes App?!

@juliusknorr
Copy link
Member

juliusknorr commented Sep 7, 2023

Should be fixed by #4735 with the next round of releases

@rhabacker
Copy link

This bug is also back in version 30.0.4 - the tab key no longer indents bullet points at unordered lists

@max-nextcloud
Copy link
Collaborator

This bug is also back in version 30.0.4 - the tab key no longer indents bullet points at unordered lists

Just tested and could not reproduce. See video below. Could you provide step by step instructions how to reproduce?

Bildschirmaufzeichnung.vom.2025-01-15.10-05-39.mp4

@rhabacker
Copy link

  1. open the Readme.md file in my Nextcloud folder
  2. select “unordered list” - a bullet point appears
  3. enter text
  4. press return - a new bullet point appears in the next line
  5. press Tab - the cursor ('|') disappears
  6. press the tab key again - a black rounded rectangle appears around the 'X' button in the top right-hand corner

It looks like the tab key changes the input focus to the next widget

I tested this with Firefox 128.6.0esr and Chrome 132.0.6834.83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants