Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readonly notes #1487

Open
bonswouar opened this issue Mar 20, 2022 · 1 comment
Open

Support readonly notes #1487

bonswouar opened this issue Mar 20, 2022 · 1 comment

Comments

@bonswouar
Copy link

Is your feature request related to a problem? Please describe.
For example when you share a note (via file sharing, as the direct share functionality isn't implemented yet #231) with restricted permissions.
If the read-only user tries to open and edit it within the Android app, it will stay stuck on "Synchronization failed", he then won't ever be able to re-sync it again.
Even the "Cancel" option doesn't work, it looks like it's still trying to push something (shouldn't this action affect only the local storage?).

Describe the solution you'd like
As with the web view, prevent Edit view on notes without write permission

Describe alternatives you've considered
It would be also be very beneficial imo to fix the "Cancel" action, I believe this should act like a "git checkout" and simply retrieve the server's file version?

@stefan-niedermann
Copy link
Member

Absolutely, I agree. For users stumbling over this issue: The currently only known workaround is to remove and readd the account from the Notes Android app (after backing up unsynchronized changes).

ToDo

  • Add a flag readonly to the notes entity
  • Check property when fetching notes (it is already sent by the API, we are just ignoring it) and update it in the database
  • Check HTTP 403 responses when pushing local changes to remote and set readonly to true for the given note. Maybe we should duplicate the note to prevent loosing the changed data(?)
  • Add some hints on the UI, if a note is marked as readonly

@stefan-niedermann stefan-niedermann changed the title Disable Edit view when file has no write permission Support readonly notes Mar 20, 2022
@stefan-niedermann stefan-niedermann pinned this issue Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants