Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Radius on Widget too big #1441

Open
newhinton opened this issue Jan 4, 2022 · 5 comments
Open

Card Radius on Widget too big #1441

newhinton opened this issue Jan 4, 2022 · 5 comments
Labels

Comments

@newhinton
Copy link
Contributor

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

The Radius is too big to look good. It comes too close to the content in the corners which looks strange

To Reproduce
Steps to reproduce the behavior:

  1. Create Widget with text

Expected behavior

A smaller radius would be better

Screenshots

Screenshot_20220104-113544_Trebuchet

Smartphone (please complete the following information):

  • Nextcloud Notes-Version (android app): 3.4.18
  • F-Droid or Play Store: FDroid
  • Android-Version: Lineageos 18.1
  • Device:

Server

  • Nextcloud version:
  • Nextcloud Notes version (server app):

Stacktrace

@stefan-niedermann
Copy link
Member

I agree that it looks like shit, but that's what Android does starting with version 12 (they called it "improvements").

Since they decided to just crop the widgets to this huge border radius and i won't maintain different widgets per Android version, we'll have to stick with it.

@newhinton
Copy link
Contributor Author

I feared something like that was the reason for the change. Maybe increasing margin_left/margin_right to fit the bottom and top margins will make it look better?

The examples dont look too bad, but they use icons in the corner which helps to hide the issue a bit

@newhinton
Copy link
Contributor Author

On a sidenote, will you support the new compound buttons so that users can change checkbox states from the widget?

@jancborchardt
Copy link
Member

Maybe increasing margin_left/margin_right to fit the bottom and top margins will make it look better?

Yeah, that seems like a good improvement.

Also, is it possible to make the top and bottom behave like padding and not like margin – so that the text is only cut off at the widget top and bottom, and not before?

@stefan-niedermann stefan-niedermann added the UX user experience label Jan 17, 2022
@abdusalamApps
Copy link

abdusalamApps commented Oct 8, 2022

It looks fine on OnePlus Nord with 6.44 inch screen, but looks like the picture provided in the issue on Galaxy S9 with 5.8 inch screen.
However, I created a pull request for this issue. I hope it gets approved and merged
Here: #1588
@newhinton @stefan-niedermann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants