Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Custom config.php per Pico site #30

Open
GregSutcliffe opened this issue Oct 5, 2017 · 6 comments
Open

RFE: Custom config.php per Pico site #30

GregSutcliffe opened this issue Oct 5, 2017 · 6 comments

Comments

@GregSutcliffe
Copy link

Many of the custom themes available for Pico require you to add things to config.php for them to display properly. It's be great to be able to put a custom config.php in the Nextcloud directory to enable using such themes.

Example: https://github.com/xupefei/Travelify#installation

@ArtificialOwl
Copy link
Member

adding config.php means that your users can execute PHP within the nextcloud environement, and it is a no go.

@GregSutcliffe
Copy link
Author

There's no way to sandobx / sanitize it? Unfortunate. Presumably this means the only option is rewriting themes to use variables from the YAML frontmatter?

@ArtificialOwl
Copy link
Member

citing @PhrozenByte YAML-based config are included in Pico 2.0. However, not sure he will find the time to backport it to 1.x.

@ArtificialOwl ArtificialOwl reopened this Oct 6, 2017
@GregSutcliffe
Copy link
Author

Yeah, I wouldn't expect that to happen - perhaps this ticket should become "Can the Nextcloud app be upgraded to Pico 2.0?" :)

@fbclol
Copy link

fbclol commented Jan 31, 2018

it's a shame that we can not change the config theme.
it breaks all the interest to have the possibility to have the choice between the themes and to have more sites.

I think that by thinking about it we could at least load a config by theme without being able to change it from the interface of nextcloud

@nsrosenqvist
Copy link

Why not just restrict it to only allow a config.yml in the root of the site? That way it must be parsed through YAML and won't allow arbitrary PHP code to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants