Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutator webhook does not support native sidecars #471

Open
mmerrill3 opened this issue Sep 20, 2024 · 1 comment
Open

Mutator webhook does not support native sidecars #471

mmerrill3 opened this issue Sep 20, 2024 · 1 comment
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@mmerrill3
Copy link

mmerrill3 commented Sep 20, 2024

When using native sidecars in a pod, the pods that the mutator uses, newrelic-infra-operator, do not support native side cars in k8s.

Description

The output when trying to apply a pod with a native sidecar, and the mutator webhook enabled for all pods in all namespaces.

  • spec.initContainers[1].livenessProbe: Forbidden: may not be set for init containers without restartPolicy=Always
  • spec.initContainers[1].readinessProbe: Forbidden: may not be set for init containers without restartPolicy=Always
  • spec.initContainers[1].startupProbe: Forbidden: may not be set for init containers without restartPolicy=Always

Expected Behavior

Pod creation is ok.

Troubleshooting or NR Diag results

Provide any other relevant log data.
TIP: Scrub logs and diagnostic information for sensitive information

Steps to Reproduce

Enable the webhook in a cluster.
Try to install a pod with a native sidecar. This is an init container with a restartPolicy set to Always, and startup, readiness, and liveness probes configured.

Your Environment

EKS, kubernetes 1.29

new relic infra operator version v0.19.2

Additional context

For Maintainers Only or Hero Triaging this bug

Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@mmerrill3 mmerrill3 added the bug Categorizes issue or PR as related to a bug. label Sep 20, 2024
@workato-integration
Copy link

mmerrill3 added a commit to mmerrill3/newrelic-infra-operator that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant