From a2d7d106bc80acb1b6df9eb327efcd3042c5d20a Mon Sep 17 00:00:00 2001 From: Emilio Garcia Date: Fri, 2 Aug 2024 11:12:21 -0400 Subject: [PATCH 1/5] bump go test versions --- .github/workflows/ci.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a25740c8b..dcf6e62e5 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,12 +15,14 @@ jobs: matrix: include: # Core Tests on 3 most recent major Go versions - - go-version: 1.19.0 - dirs: v3/newrelic,v3/internal,v3/examples - go-version: 1.20.0 dirs: v3/newrelic,v3/internal,v3/examples - go-version: 1.21.0 dirs: v3/newrelic,v3/internal,v3/examples + - go-version: 1.22.0 + dirs: v3/newrelic,v3/internal,v3/examples + - go-version: 1.23.0 + dirs: v3/newrelic,v3/internal,v3/examples # Integration Tests on highest Supported Go Version - dirs: v3/integrations/nramqp From 0b0c7c53694cf42b8a478ca3c17daaf45aa676a4 Mon Sep 17 00:00:00 2001 From: Emilio Garcia Date: Fri, 2 Aug 2024 11:41:44 -0400 Subject: [PATCH 2/5] fix docker golang versioning --- .github/workflows/ci.yaml | 16 ++++++++-------- Dockerfile | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index dcf6e62e5..cd4ffc42b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -4,7 +4,7 @@ name: Go Agent CI on: pull_request env: # Specifies which go version to run integration tests on - INTEGRATION_TESTS_GO_VERSION: 1.21.5 + INTEGRATION_TESTS_GO_VERSION: latest jobs: go-agent-v3: @@ -15,13 +15,13 @@ jobs: matrix: include: # Core Tests on 3 most recent major Go versions - - go-version: 1.20.0 + - go-version: 1.20 dirs: v3/newrelic,v3/internal,v3/examples - - go-version: 1.21.0 + - go-version: 1.21 dirs: v3/newrelic,v3/internal,v3/examples - - go-version: 1.22.0 + - go-version: latest dirs: v3/newrelic,v3/internal,v3/examples - - go-version: 1.23.0 + - go-version: 1.23rc2 dirs: v3/newrelic,v3/internal,v3/examples # Integration Tests on highest Supported Go Version @@ -109,11 +109,11 @@ jobs: matrix: include: # Core Tests on 3 most recent major Go versions - - go-version: 1.19.0 + - go-version: 1.20 dirs: v3/newrelic,v3/internal,v3/examples - - go-version: 1.20.0 + - go-version: 1.21 dirs: v3/newrelic,v3/internal,v3/examples - - go-version: 1.21.0 + - go-version: latest dirs: v3/newrelic,v3/internal,v3/examples steps: - name: Checkout Code diff --git a/Dockerfile b/Dockerfile index 566e372ad..6c9e425f0 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,6 +1,6 @@ # This file is used to build the docker image for the Go Agent's GitHub Action tests # Default go version if no arguments passed in -ARG GO_VERSION=1.19 +ARG GO_VERSION=1.20 # Takes in go version FROM golang:${GO_VERSION} as builder From 79b74fdee2a9504bcdffe24e0bb9a490994075e8 Mon Sep 17 00:00:00 2001 From: Emilio Garcia Date: Fri, 2 Aug 2024 11:42:03 -0400 Subject: [PATCH 3/5] tweaks to auto assign, and bump version --- .github/auto_assign.yml | 2 +- .github/workflows/autoassign.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/auto_assign.yml b/.github/auto_assign.yml index 577a2b50a..d023b4236 100644 --- a/.github/auto_assign.yml +++ b/.github/auto_assign.yml @@ -2,7 +2,7 @@ addReviewers: true # Set to true to add assignees to pull requests -addAssignees: false +addAssignees: true # A list of reviewers to be added to pull requests (GitHub user name) reviewers: diff --git a/.github/workflows/autoassign.yml b/.github/workflows/autoassign.yml index 2960b1772..093e194ac 100644 --- a/.github/workflows/autoassign.yml +++ b/.github/workflows/autoassign.yml @@ -7,4 +7,4 @@ jobs: add-reviews: runs-on: ubuntu-latest steps: - - uses: kentaro-m/auto-assign-action@v1.2.0 \ No newline at end of file + - uses: kentaro-m/auto-assign-action@v2.0.0 \ No newline at end of file From fe0efb02314a39b5b37fc6623b1b4854cb5e7624 Mon Sep 17 00:00:00 2001 From: Emilio Garcia Date: Fri, 2 Aug 2024 11:52:49 -0400 Subject: [PATCH 4/5] go 1.20 --> 1.20.14 --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index cd4ffc42b..9780de023 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,7 +15,7 @@ jobs: matrix: include: # Core Tests on 3 most recent major Go versions - - go-version: 1.20 + - go-version: 1.20.14 dirs: v3/newrelic,v3/internal,v3/examples - go-version: 1.21 dirs: v3/newrelic,v3/internal,v3/examples @@ -109,7 +109,7 @@ jobs: matrix: include: # Core Tests on 3 most recent major Go versions - - go-version: 1.20 + - go-version: 1.20.14 dirs: v3/newrelic,v3/internal,v3/examples - go-version: 1.21 dirs: v3/newrelic,v3/internal,v3/examples From ac97a7b7a5dd2adea596951ff4a15b99ce0f4e39 Mon Sep 17 00:00:00 2001 From: Emilio Garcia Date: Fri, 2 Aug 2024 11:53:29 -0400 Subject: [PATCH 5/5] add whitespace to autoassign yml --- .github/workflows/autoassign.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/autoassign.yml b/.github/workflows/autoassign.yml index 093e194ac..6ab6507ad 100644 --- a/.github/workflows/autoassign.yml +++ b/.github/workflows/autoassign.yml @@ -7,4 +7,4 @@ jobs: add-reviews: runs-on: ubuntu-latest steps: - - uses: kentaro-m/auto-assign-action@v2.0.0 \ No newline at end of file + - uses: kentaro-m/auto-assign-action@v2.0.0