Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WikiNodeCdnWarmer: Add ability to also warm any aggregated assets for a request #4

Open
Ambient-Impact opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Ambient-Impact
Copy link
Member

Currently, only the HTML response is warmed since it's using Guzzle rather than a browser, so the former does not attempt to load any referenced stylesheets and JavaScript files like a browser would (to my knowledge). It would be possible to parse the response into a DOM that can be searched to find the appropriate elements, but that could be a security issue if we assume the content is trusted when it may have been tampered with.

A better and more secure solution would remove the need for a round trip over the network and instead get a list of aggregates from the database. It doesn't look like there's a complete list of aggregates in cache or state (though some JS in state), so what we could do is to save that information in cache when aggregate URLs are generated, and then retrieve those from cache (in a second warmer plug-in?) and request them.

@Ambient-Impact Ambient-Impact added the enhancement New feature or request label Nov 20, 2024
@Ambient-Impact Ambient-Impact moved this to Todo in Performance Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant