Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minification: emit_attributes() should pick single or double quotation form for escaping #164

Open
raphaelcohn opened this issue Dec 11, 2017 · 1 comment
Open

Increase minification: emit_attributes() should pick single or double quotation form for escaping #164

raphaelcohn opened this issue Dec 11, 2017 · 1 comment
Labels
feature would be nice to have

Comments

@raphaelcohn
Copy link

A nice feature to improve minification would to let emit_attributes() choose to use either a single or double quoted form for attribute values depending on the presence of double or single quotes in the attribute value to be escaped. This obviously has a performance hit, so it should be an option in EmitterConfig.
@netvl
Copy link
Owner

netvl commented Jan 8, 2018

Good idea! Pull requests are of course welcome. Not sure if I will be able to work on this any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature would be nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netvl @raphaelcohn