Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presenter::$invalidLinkMode is silent by default and can't be overwritten by config #337

Open
forgie1 opened this issue Nov 3, 2024 · 1 comment
Open

Presenter::$invalidLinkMode is silent by default and can't be overwritten by config #337

forgie1 opened this issue Nov 3, 2024 · 1 comment

Comments

@forgie1
Copy link

forgie1 commented Nov 3, 2024

Version: 3.2.6

Bug Description

This commit broke it: 244fc48
Because of condition here: https://github.com/nette/application/blob/v3.2.6/src/Bridges/ApplicationDI/PresenterFactoryCallback.php#L58
Link mode keeps being set to 0.

So no warning is thrown that link is broken.
@forgie1 forgie1 changed the title Presenter::i$nvalidLinkMode is silent by default and can't be overwritten by config Presenter::$invalidLinkMode is silent by default and can't be overwritten by config Nov 3, 2024
@SharavananAK
Copy link

$presenter instanceof Nette\Application\UI\Presenter && !isset($presenter->invalidLinkMode
As the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forgie1 @SharavananAK