Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Entity's Data Attachments visible through EntityRenderState #1638

Open
Drullkus opened this issue Oct 27, 2024 · 0 comments · May be fixed by #1650
Open

Make Entity's Data Attachments visible through EntityRenderState #1638

Drullkus opened this issue Oct 27, 2024 · 0 comments · May be fixed by #1650
Labels
enhancement New (or improvement to existing) feature or request

Comments

@Drullkus
Copy link
Contributor

Starting with 1.21.2, Minecraft switched Entity Renderers to using EntityRenderState extensions. If a mod were using a RenderLayer to render DataAttachment information (as bound to renderer via EntityRenderersEvent.AddLayers) before this update, this option is now completely impossible without assistance of coremodding.

A possible solution is to copy the Data Attachment map (or wrapping a view) for mods to restore their DataAttachment-based rendering additions for entities.
@Drullkus Drullkus added the enhancement New (or improvement to existing) feature or request label Oct 27, 2024
@dhyces dhyces linked a pull request Oct 31, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1.21.3] UpdateRenderStateEvent and EntityRenderState extends AttachmentHolder dhyces/NeoForge
1 participant
@Drullkus