Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonHooks.getCraftingRemainingItem not used #1585

Open
ewoudje opened this issue Oct 9, 2024 · 0 comments
Open

CommonHooks.getCraftingRemainingItem not used #1585

ewoudje opened this issue Oct 9, 2024 · 0 comments
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error

Comments

@ewoudje
Copy link

ewoudje commented Oct 9, 2024

Minecraft Version: 1.21.1

NeoForge Version: 21.1.65

Description of issue:
CommonHooks.getCraftingRemainingItem never gets called, instead all calls are done directly via IItemStackExtension.
I'm assuming patched calls should make use of the hook instead of the method in IItemStackExtension or in IItemStackExtension a call to CommonHooks.getCraftingRemainingItem.

Not doing this causes it to not detect broken items and thus not firing PlayerDestroyItemEvent which has in its docs that it should fire under these circumstances.
@ewoudje ewoudje added the triage Needs triaging and confirmation label Oct 9, 2024
@XFactHD XFactHD added bug A bug or error 1.21.1 Targeted at Minecraft 1.21.1 and removed triage Needs triaging and confirmation labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewoudje @XFactHD