Neo v3.5.0 Checklist

[superboyiii]

Now we're making the checklist of neo v3.5.0 for release preparation. We plan to release v3.5.0 at the end of September.

Mandatory issues

• Check notifications for manifest compliance #1879
• Assert and Safe methods #2782
• RpcClient.GetBlockHashAsync index parameter should be uint neo-modules#756
• Add a FindOption to control SeekDirection of Storage.Find #2789
• RpcServer should support missing params request property neo-modules#768

Mandatory PRs

• Allow contracts to load script at runtime dynamically #2756
  Fix Safe Assert #2784 (need further discussion)
• Native: store ID->hash map in ContractManagement, add iterator #2807
  Check ABI for notifications #2810 (will be included in v3.6.0)
  node: Mode system neo-node#853 (need further discussion)
  featured log neo-node#848 (need further discussion)
  add logs to execution neo-modules#737 (need further discussion)
• Allow parameterless requests neo-modules#747
• Add SQLiteWallet neo-modules#752
• Fix RpcClient neo-modules#757
  Update neo 3.6 neo-devpack-dotnet#758 (need further discussion)
  No reentrant modifier neo-devpack-dotnet#756 (need further discussion)
  Remove unnecessary default seedlist #2773 (need further discussion)
  Add committee change events #2764 (need further discussion)
• Just extend by factor if commit is from current view neo-modules#762
  Payloads: add NotValidBefore transaction attribute #2812 (need further discussion)
• add throwOnError param to RpcClient Send/SendAsync neo-modules#763
• Plugin file watcher only reminds user to restart node #2823
• RpcServer should support missing params request property neo-modules#769
• Fix rpc signer rules neo-modules#773
• Fix scriptbuilder EmitPush(bool) neo-vm#493
• Add PUSHT and PUSHF neo-vm#497
• Update Debug Info Format neo-devpack-dotnet#770
• Fix MaxBlockSystemFee neo-modules#774

@neo-project/core @neo-project/developers @neo-project/ngd-seattle

[roman-khimov]

It'd be nice to have some definitive answer on #2773 for this release. Not that it's critical, but it's a pretty simple change to me, so we should at least make some decision on it after three months in the queue (my vote would be for accepting it).

Also, we'll try to prepare patches for #1992 and #1991 (as was proposed in #2661 (comment)), those would be nice to have in 3.5.0.

Worth considering: #2789 (trivial to implement, adds some possibilities), #2764.

[roman-khimov]

How about neo-project/neo-modules#762 and #2812?

[superboyiii]

How about neo-project/neo-modules#762 and #2812?

Added

[devhawk]

please add neo-project/neo-modules#763

[superboyiii]

please add neo-project/neo-modules#763

Done.

[ZhangTao1596]

Please add neo-project/neo-modules#765

[Jim8y]

This pr #2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

[superboyiii]

This pr #2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

Done

[superboyiii]

Please add neo-project/neo-modules#765

Done

[devhawk]

any chance of adding neo-project/neo-modules#768? It should be a pretty minor fix

[superboyiii]

any chance of adding neo-project/neo-modules#768? It should be a pretty minor fix

Done

[devhawk]

Is there an updated target date for 3.5 release?

[superboyiii]

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

[ixje]

Can we please include neo-project/neo-vm#493

[devhawk]

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

I'm on the road for campus tour so I'm not in a position to review current state. @shargon and @roman-khimov are likely in a better position to judge this

[shargon]

For me Fix assert is an important one

[devhawk]

@superboyiii can we include neo-project/neo-devpack-dotnet#770 in 3.5? It's a minor update to the debug info

[devhawk]

FYI, neo-project/neo-devpack-dotnet#770 is ready to merge

[superboyiii]

@neo-project/everyone https://github.com/neo-project/neo-node/releases/tag/v3.5.0