Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nep17Transfer lookups #2553

Open
spencercorwin opened this issue Sep 23, 2021 · 0 comments
Open

Fix Nep17Transfer lookups #2553

spencercorwin opened this issue Sep 23, 2021 · 0 comments
Labels
area/node Categorize issue or PR as node (@neo-one/node) related kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@spencercorwin
Copy link
Collaborator

When looking up Nep17Transfers with the RPC method 'getnep17transfers' I noticed strange behavior when trying to get all nep 17 transfers for a certain address in between startTime and endTime. It doesn't work correctly. Storage lookup params change when we pass each max byte mark. ie. 0 to 255 time is different than 0 to 256. Going into detail here would be very verbose. But it's not the expected behavior. To figure out what the search range keys are supposed to look like we need to see the exact bytes that are used in the neo-modules C# version. And need to understand better how storage iterator lookups work. We may need to create a Nep17TransferKey() object for the lookup and serialize it with zeros after the scripthash and timestampMS are serialized.

@spencercorwin spencercorwin added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. area/node Categorize issue or PR as node (@neo-one/node) related labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/node Categorize issue or PR as node (@neo-one/node) related kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

1 participant