Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check/Look Out For Correct EC Curve Calculations #2523

Open
spencercorwin opened this issue Jul 22, 2021 · 0 comments
Open

Check/Look Out For Correct EC Curve Calculations #2523

spencercorwin opened this issue Jul 22, 2021 · 0 comments

Comments

@spencercorwin
Copy link
Collaborator

In RC4 NF found and fixed a bug in Crypto.VerifySignature() having to do with EC curve differences on macOS vs Linux/Windows. But it appeared to me that there was no need to make this related change in our code. So I didn't change our crypto.verify() method. But just in case there is an obscure inconsistency, it could be due to this change.

Here is where they account for macOS: https://github.com/neo-project/neo/blob/master/src/neo/Cryptography/Crypto.cs#L67

Here is our verify method: https://github.com/neo-one-suite/neo-one/blob/master/packages/neo-one-client-common/src/crypto.ts#L97

And this is the PR for the Neo repo change: neo-project/neo#2511 and neo-project/neo#2546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant