Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LIF.min_voltage #163

Open
tcstewar opened this issue Jan 7, 2019 · 1 comment
Open

Support LIF.min_voltage #163

tcstewar opened this issue Jan 7, 2019 · 1 comment

Comments

@tcstewar
Copy link
Contributor

tcstewar commented Jan 7, 2019

At the moment, nengo_ocl doesn't support LIF.min_voltage values other than 0. How hard would it be to add support for this? Would it just be a matter of adding it to https://github.com/nengo/nengo-ocl/blob/nengo-dev/nengo_ocl/simulator.py#L872 and adjusting https://github.com/nengo/nengo-ocl/blob/nengo-dev/nengo_ocl/clra_nonlinearities.py#L958 and https://github.com/nengo/nengo-ocl/blob/nengo-dev/nengo_ocl/clra_nonlinearities.py#L977 ?

@hunse
Copy link
Collaborator

hunse commented Jan 9, 2019

You'd have to make it a parameter like tau, ref and amp, and pass it in that way. So that would change some of the function you identified in simulator.py, and more of the one in clra_nonlinearities.py. But overall, not too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants