Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin-api] remains silent when trying to assign an existing accession ID #1214

Open
2 tasks
aaperis opened this issue Dec 19, 2024 · 1 comment
Open
2 tasks
Labels
bug Something isn't working

Comments

@aaperis
Copy link
Contributor

aaperis commented Dec 19, 2024

Describe the bug

This bug is in the api and should be fixed there
The examples below just makes this easier to test.

We have the restriction that an accession ID should be unique regardless if the user name is different.

If one tries to assign an existing accession ID to a file

Steps to reproduce

./sda-admin file set-accession -filepath requester_demo.org/t1.txt.c4gh -user [email protected] -accession-id my-access-1

then after ingesting a file with a different user:

./sda-admin file set-accession -filepath test_dummy.org/t1.txt.c4gh -user [email protected] -accession-id my-access-1

finalize returns:

{"level":"debug","msg":"Seems accession ID already exists (corr-id: fb84528e-1146-4089-ad64-a09cd494f725, accessionid: my-access-1","time":"2024-12-19T09:34:07Z"}

but sda-admin remains silent.

Expected behavior

  • sda-admin returns an informative message to the user
  • Tests verifying the fix are added

Additional context

Estimation of size

smal

Estimation of priority

low/medium

@aaperis aaperis added the bug Something isn't working label Dec 19, 2024
@jbygdell jbygdell changed the title [sda-admin] remains silent when trying to assign an existing accession ID [admin-api] remains silent when trying to assign an existing accession ID Dec 19, 2024
@jbygdell
Copy link
Collaborator

Moved to admin api since that's where it needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants