Release notes incorrect when using TagStrategy setPrefixNameWithV(false)

[sdavids13]

When using TagStrategy setPrefixNameWithV(false) the full contents of the Git history is contained in every release notes section. This is because the TagStrategy generateMessage closure grabs the "previousVersion" and always prefixes "v" in front of the commit that is looked up in the git repository (for which it never finds the commit since it's not there). The code of interest can be found here:

nebula-release-plugin/src/main/groovy/nebula/plugin/release/ReleasePlugin.groovy

Lines 113 to 122 in af18e2f

	if (version.previousVersion) {
	String previousVersion = "v${version.previousVersion}^{commit}"
	List excludes = []
	if (tagExists(grgit, previousVersion)) {
	excludes << previousVersion
	}
	grgit.log([includes: ['HEAD'], excludes: excludes]).inject(builder) { bldr, Commit commit ->
	bldr << "- ${commit.id}: ${commit.shortMessage}\n"
	}
	}

[sdavids13]

Quick follow-up, looks like the OpinionReleasePlugin accounts for the distinction here:
https://github.com/nebula-plugins/nebula-release-plugin/blob/main/src/main/groovy/nebula/plugin/release/git/opinion/OpinionReleasePlugin.groovy#L71

With the test case being found here:
https://github.com/nebula-plugins/nebula-release-plugin/blob/main/src/test/groovy/nebula/plugin/release/git/opinion/OpinionReleasePluginSpec.groovy#L62-L82

So, it appears the ReleasePlugin line 114 should simply be changed to:
String previousVersion = "${project.release.tagStrategy.toTagString(version.previousVersion)}^{commit}"

[sdavids13]

PR that fixes this issue: #222