Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark results need updating #536

Open
Gobd opened this issue Jan 12, 2025 · 2 comments · May be fixed by #535
Open

Benchmark results need updating #536

Gobd opened this issue Jan 12, 2025 · 2 comments · May be fixed by #535

Comments

@Gobd
Copy link

Gobd commented Jan 12, 2025

See auth0/node-jsonwebtoken#966 and update the benchmarks with the best practices suggested to make benchmark results reflect current versions.

@Gobd Gobd linked a pull request Jan 12, 2025 that will close this issue
@ilteoood
Copy link
Contributor

As you can see by simply blaming the README.md file, the benchmarks have been executed more than 5 years ago, which is far before the creation of that issue and the introduction of that regression.
image

Can the benchmark be improved? Of course!
Have we been unfair? Absolutely no.

@Gobd
Copy link
Author

Gobd commented Jan 12, 2025

Sorry I didn't mean to imply any wrongdoing or anything, I didn't notice the benchmarks were that old! I just like accurate benchmarks so I can make good decisions about what packages to use :)

@Gobd Gobd changed the title Benchmark results are unfair to jsonwebtoken Benchmark results need updating Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants