-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic types to create functions #225
Comments
Absolutely! Please remember to include tests for the types in https://github.com/nearform/fast-jwt/blob/master/test/types.spec.ts |
@avin-kavish any update on this? |
yeah, I did some work few months back. It's in #258 I don't think it's complete though. |
Thanks. Are you planning to complete it? |
yeah, at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it would be good to have these functions generically typed. If we know the shape of the payload, we can pass it here and get better type completion.
Would you accept a PR for this?
The text was updated successfully, but these errors were encountered: