You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Protocol upgrades should always be done between successive protocol versions, upgrading from X to X+1 is fine, but X to X+10 is not supported.
We have multiple tests which perform an upgrade from version X directly to the latest version. It'd be good to fix them so that they don't perform unsupported operations. It causes issues when trying to write new protocol upgrade code that should be able to rely on the fact that the upgrade will be performed from the previous protocol version, not one far in the past.
Here are some bad tests that I ran into when trying to implement bandwidth scheduler protocol upgrade:
Protocol upgrades should always be done between successive protocol versions, upgrading from X to X+1 is fine, but X to X+10 is not supported.
We have multiple tests which perform an upgrade from version X directly to the latest version. It'd be good to fix them so that they don't perform unsupported operations. It causes issues when trying to write new protocol upgrade code that should be able to rely on the fact that the upgrade will be performed from the previous protocol version, not one far in the past.
Here are some bad tests that I ran into when trying to implement bandwidth scheduler protocol upgrade:
It looks like most of them use
TestEnv::upgrade_protocol_to_latest_version()
. We should fix it to allow upgrading to a specific version. Refs: #8590The text was updated successfully, but these errors were encountered: