Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Move on-demand contract compilation out of unstable. #361

Open
ruseinov opened this issue Jun 26, 2024 · 2 comments
Open

[Enhancement] Move on-demand contract compilation out of unstable. #361

ruseinov opened this issue Jun 26, 2024 · 2 comments

Comments

@ruseinov
Copy link

ruseinov commented Jun 26, 2024

It would be nice to move this out of unstable feature.

It seems to work quite well as seen in: near/near-sdk-rs#1195 . It does end up calculating different Gas depending on the machine/rust version, but that's to be expected with any kind of compilation.

Will take this on soon.

@frol
Copy link
Collaborator

frol commented Jun 29, 2024

This is blocked on getting the reproducible builds feature in cargo-near: near/cargo-near#134, and then we would need to extract that functionality from the CLI into a standalone crate. Currently, it is better to keep compile_project feature under a feature flag since otherwise it pulls in quite a bulk of outdated dependencies.

@ruseinov
Copy link
Author

This is blocked on getting the reproducible builds feature in cargo-near: near/cargo-near#134, and then we would need to extract that functionality from the CLI into a standalone crate. Currently, it is better to keep compile_project feature under a feature flag since otherwise it pulls in quite a bulk of outdated dependencies.

Let's keep it in the backlog for now then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants