Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should be explicit for a mistakenly used reserved identifier #1166

Open
joe-rlo opened this issue Apr 10, 2024 · 3 comments
Open

Comments

@joe-rlo
Copy link

joe-rlo commented Apr 10, 2024

Just a suggestion but when a reserved identifier is used the error output should reference that it is a reserved identifier since that may be causing the error.

for example, I used attached_deposit == self.fee_amount, by mistake and the error just kept saying expected 'NearToken', found 'u128'

The error should say something like expected 'NearToken', found 'u128', note: attached_deposit is a reserved identifier

@joe-rlo joe-rlo changed the title Error message should be explicit for a mistakenly used reserved term. Error message should be explicit for a mistakenly used reserved identifier Apr 10, 2024
@frol
Copy link
Collaborator

frol commented Jul 29, 2024

@joe-rlo There is no reserved identifier as far as I know. Can you share the code where you hit it?

@frol
Copy link
Collaborator

frol commented Jul 30, 2024

I wonder if it is related to #812

@joe-rlo
Copy link
Author

joe-rlo commented Jul 30, 2024

I cannot find the original code I was referencing but it does look similar to #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

No branches or pull requests

2 participants