Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh Hebrew Translation #121

Open
TheBooker66 opened this issue Jan 13, 2022 · 4 comments
Open

Fresh Hebrew Translation #121

TheBooker66 opened this issue Jan 13, 2022 · 4 comments

Comments

@TheBooker66
Copy link

TheBooker66 commented Jan 13, 2022

I started a new Hebrew translation repo because the old one has been inactive for 5 years.
I'm having problems with the hitboxes of the buttons not being on the buttons, rather to their left. I know the source is the dir="rtl" tag I put in the html element in index.html, but it's needed to align everything correctly. Other right to left language translations have solved this issue, but I'm unsure how and google isn't helping.

@TheBooker66
Copy link
Author

I've managed to fix the rtl issue, and have already translated half of words.html and all of index.html & peeps/index.html. I'll probably finish within a week.

@TheBooker66
Copy link
Author

I have finished translation of everything apart of notes/index.html, and I've run into one bug which I haven't been able to fix: Slides 3 to 7 just don't load (4 loads the first screen but not anything after it and 6 loads until after the character screen). I probably messed something up with the js files dealing with the tournament system as I've meddled with all the files (mostly because Hebrew is a right-to-left language and so adjustments to the code had to be made) I would appreciate it if you (@ncase) took a look at my repo and suggested a solution (if you think of one) off of your experience.

@Hexag0nSun
Copy link

Hi @TheBooker66 !
Was there any further progress on this? This game just popped up in my facebook memories and a Hebrew translation might be useful. albeit I'm not sure the design works well on mobile

@TheBooker66
Copy link
Author

@Hexag0nSun Hey, I haven't progressed on this since last time. All the code is in a repo on my profile, if you want to have a look. Again, mostly translated; just doesn't really work :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants