Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to label traffic as local #17

Open
snppla opened this issue Jan 10, 2021 · 2 comments · May be fixed by #18
Open

Feature to label traffic as local #17

snppla opened this issue Jan 10, 2021 · 2 comments · May be fixed by #18

Comments

@snppla
Copy link

snppla commented Jan 10, 2021 •
edited
Loading

I am most interested in tracking traffic to and from the internet with my router and not so much traffic that is internal to my network. It would be nice if when the source and destination both match the network range parameter, that a tag called "traffic_type" is set to local, otherwise it would be set to external (Using a tag instead of a boolean field to allow for faster searching).

I'll be forking this project and creating a pull request of this feature, but would like some feedback if this would be accepted back into this codebase.
@snppla snppla linked a pull request Jan 10, 2021 that will close this issue
Open
@ncareau
Copy link
Owner

ncareau commented Jan 11, 2021

Hey, thanks for the suggestion and the pull request. It might take the week before I check but i will give feedback and merge if everything is ok. I should be able to put some time on it before the end of next week.

Thanks again.

@ncareau
Copy link
Owner

ncareau commented Jan 17, 2021

I took a look at your suggestion and it is a great idea. However, I think that if we go down that route, we need to add both local and external traffic separately. I would add $local_down_byte and $external_down_byte. That way, people who just need external can also plot their graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added traffic_type tag snppla/Mikro-Watch
2 participants
@snppla @ncareau