Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore /print endpoint #3827

Open
lucastucious opened this issue Oct 14, 2024 · 8 comments
Open

Restore /print endpoint #3827

lucastucious opened this issue Oct 14, 2024 · 8 comments
Labels
solution found A solution exists; just needs to be applied tweak Small, non-breaking change

Comments

@lucastucious
Copy link
Contributor

Your idea:

Ok so it seems too little to be a github issue, but i can't make a /print endpoint working. I was able to generate pdf from other browsers/tools with it but now every /print link is broken and i can't find any alternative.

My use case is that I was using https://www.princexml.com/ to print pdf. The tool have severals QoL like having title converted to pdf bookmarks, custom css override, automation.
Another one is to sending /print link directly to users that don't know homebrewery and how to generate a pdf.

A third one, is to have page that you can inspect to track issue, without worrying about all the editors scripts. Just straight html.

So, I don't know why it was removed, but I would love to get it back

@5e-Cleric
Copy link
Member

So, yes, you are not the only one asking for this, so it will likely get added back, in some way or another.

We removed the print endpoint because we assumed everyone was using it exclusively for printing.

So far, 2 people have reported they used princeXML, and another one that they used it to check brews in mobile.

Even if we restore it, there has been talk about changing how it worked, but the end result should be very similar.

Apart from that, we could also provide a download as html feature, would that also be desirable? I am not sure how does princeXML works.

@5e-Cleric 5e-Cleric changed the title Can we get back the /print endpoint ? Restore /print endpoint Oct 14, 2024
@5e-Cleric 5e-Cleric changed the title Restore /print endpoint Restore /print endpoint Oct 14, 2024
@lucastucious
Copy link
Contributor Author

For prince, a html download can surely work !

@calculuschild
Copy link
Member

Another one is to sending /print link directly to users that don't know homebrewery and how to generate a pdf.

At least for this case, it's possible to just send people a PDF you already made.

@ericscheid ericscheid added solution found A solution exists; just needs to be applied tweak Small, non-breaking change labels Oct 15, 2024
@ericscheid
Copy link
Collaborator

The old endpoint worked well but was considered redundant.

IIRC, it would be all in one pane (no iframes) and it would also do the initial render on the server, thus sending the full rendered html to the browser. Restoring that would be a good start towards doing a download as html too.

@5e-Cleric
Copy link
Member

The old endpoint worked well but was considered redundant.

IIRC, it would be all in one pane (no iframes) and it would also do the initial render on the server, thus sending the full rendered html to the browser. Restoring that would be a good start towards doing a download as html too.

I'd say we want to avoid previous issues, we don't want to need to update this endpoint, so it needs to build from the same template we use for brewrenderer, we might want to extract it as a separate component.

@lucastucious
Copy link
Contributor Author

Just asking why this issue is flagged as "solution found" ? Because right now there is no way to have a pure html view ...?

@5e-Cleric
Copy link
Member

Do read the label's tip when hovered, a solution is found, just needs to be applied.

@dbolack-ab
Copy link
Collaborator

Do read the label's tip when hovered, a solution is found, just needs to be applied.

Which solution is that?

The endpoint return works for a better for things like DocRaptor. I don't expect you're pointing folks at https://github.com/dbolack-ab/hbraptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution found A solution exists; just needs to be applied tweak Small, non-breaking change
Projects
None yet
Development

No branches or pull requests

5 participants