JetStream Direct Get Batch / Multi Last

[charbonnierg]

Hi everyone,

NATS 2.11 is coming soon, and will bring 2 new features:

• JetStream Direct Get Batch Requests
• JetStream Direct Get Multi-subject Requests

Those two features have been implemented in jsm.go in this PR.

I tried to come up with an implementation in Python, here's how it's used: https://github.com/charbonnierg/nats.py/blob/feat/multi_direct_get/examples/direct_get.py

What do you think about this API ?

@wallyqs would you be interested in a PR ? If so, could you please describe the kind of tests that you would expect, and if it would be ok to write those tests with pytest in a new module rather than bloating the existing test_js.py which is already > 4000 LOC

@bruth I know you're not actively contributing to this repo, but your opinion could also be extremely useful 😊

Also, I guess that once the batch direct get is supported, it should also be possible to implement a get_many or something similar for KV stores, but I don't have a strong opinion on the API to use, neiter did I look into other client implementations to get an idea.

[wallyqs]

@charbonnierg a PR here would be very welcome! How about adding the test in a different file bucketing the v2.11 features? like test_js_v2_11.py?

[charbonnierg]

Sounds like a good idea 👍 I'll try to do that then !
Would you be ok with tests using pytest ? Since pytest is used to discover and run tests I don't think that should be a problem. I find @pytest.mark.parametrize to be extremely useful when writing test cases.

[wallyqs]

that sounds good to me, using pytest is fine