-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature]: DISP-S1 Support for Validator Tool #944
Comments
@philipjyoon - did I capture the logic correctly? The above would apply for FWD or HIST regardless, assuming enough time has passed. |
@riverma There are a few more dimensions to this:
We discussed one more dimension which we hadn't decided whether it was worth the complexity: verifying the K- and M- files used as input files in producing the DISP-S1 products. There are two ways to look at those K- and M- input files:
(to be continued... I'll write out what I think should be the overall logic tomorrow morning) |
Sample logic:
Comparison Options:
Some key resources needed:
|
@philipjyoon - thank you so much for writing out these excellent and clear points! Extremely helpful. I have a few follow-up questions:
Hmm, can't we just use the same strategy we did for DSWx-S1? Namely:
The logic I mentioned in the above quote would tell us exactly which CSLCs we should have used. Am I missing something? How would we not know this?
Do you have a recommendation on how to import your code? I'm assuming we don't have published packages. Currently the auditing tools are within /report |
@riverma I did not realize that CMR query also returns You can use the code here as the general guideline to use |
Next steps based on discussions:
|
This tool must also take into account blackout dates |
We've been told by ASF that the input CSLC granule list CANNOT be stored in CMR because it would break. So we will need to implement this logic without that information - as @philipjyoon described in a comment on Aug 15, 2024 |
…rmining triggering logic for DISP-S1 processing for validation purposes
…ate DataFrame. Create DataFrame from CSLC analysis result
…eated unit test which is failing currently
While DISP-S1 forward processing still needs some work, we can still use it to test high-level functionality of the validator. To do so, we run |
I tested DISP-S1 historical mode validation mode in two ways:
|
Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
The DSWx-S1 validator tool currently only supports DSWx-S1. We'd like to ensure DISP-S1 is also supported.
Describe the feature request
Sample logic:
burst_to_frame.json
file to locate the frame IDs that correspond to this CSLC product.frame_to_burst.json
file to identify all the CSLC burst IDs expected for this frame.Some key resources needed:
frame_to_burst.json
orburst_to_frame.json
The text was updated successfully, but these errors were encountered: