Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset option for rate groups allowing different trigger patterns #2135

Closed
csmith608 opened this issue Jul 17, 2023 · 4 comments
Closed
Assignees

Comments

@csmith608
Copy link
Collaborator

F´ Version baremetal
Affected Component RateGroupDriver

Feature Description

Addition of an offset option when specifying rate group dividers. The offsets would be used to stagger RG firings, this is useful when a thread scheduler is not present

Rationale

This was used on the LFPS firmware and cut our rate group times almost in half preventing major rate group slipping. The image below shows an example of how the current rate group would fire off vs how the proposed change could be used to fire them off.
This is an example of how the rate groups fired before and after adding the offsets.
image

It was implemented here for fprime 3.0.0, but should have used a struct for the rate group divider and offset. However, the logic changes are there and can be used pretty much as is. Here are the relevant requested changes by @LeStarch

@ethancheez

@SMorettini
Copy link
Contributor

Hello @csmith608 , I need this feature too, are you already implementing it? Otherwise, I'll work on it next week.

@csmith608
Copy link
Collaborator Author

Hi @SMorettini, I'm excited that this feature is immediately useful. I don't have the bandwidth right now to do the implementation. I was hoping @ethancheez was going to have a chance, but I'm not sure, @LeStarch?

@SMorettini
Copy link
Contributor

@csmith608 I create the pull request since I had to implement it on my private repository as soon as possible.

@thomas-bc
Copy link
Collaborator

Merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants