Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis_example.ini should have empty telemetry file fields #107

Closed
the-other-james opened this issue Jan 4, 2024 · 4 comments · Fixed by #172
Closed

redis_example.ini should have empty telemetry file fields #107

the-other-james opened this issue Jan 4, 2024 · 4 comments · Fixed by #172

Comments

@the-other-james
Copy link
Contributor

TelemetryDataFilePath and TelemetryFile are ignored when using a data source, and thus should be left blank.

Related #101
@the-other-james
Copy link
Contributor Author

Taking a closer look... the meta file doesn't make sense to me either. Is the subscription info hard-coded?

@asgibson
Copy link
Contributor

asgibson commented Jan 9, 2024 •
edited
Loading

The meta file will contain this information, but the .ini for this has not been updated to be used as an effective example as of yet. Redis had been added for use by a project and their .ini made use of this. The parsing of the meta file is done in the __init__ function of any OnAirDataSource. Redis adapter's function, parse_meta_data_file, extracts subscription information from the meta file.

@the-other-james the-other-james mentioned this issue Nov 18, 2024
Merged
@asgibson
Copy link
Contributor

Making these values blank doesn't change the behavior at all and would be more clear. However, it would be better to have these two keywords be required for parsers (data sources that use files) and not required for adapters (live data sources). Currently the keywords are required in either case, even though adapters ignore them.

@the-other-james
Copy link
Contributor Author

I agree completely.

@asgibson asgibson linked a pull request Nov 19, 2024 that will close this issue
Redis example telemetry path and file now empty string #172
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redis example telemetry path and file now empty string nasa/OnAIR
2 participants
@the-other-james @asgibson