Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test xfail unification #1893

Open
MarcoGorelli opened this issue Jan 29, 2025 · 0 comments
Open

chore: test xfail unification #1893

MarcoGorelli opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jan 29, 2025

We're xfailing some tests in a variety of ways. I think it would be good to standardise somewhat

  • requests.applymarkers(pytest.mark.xfail): this currently fails, but we aim to be able to support it in the future
  • pytest.mark.skipif: there's some condition under which this just can't be tested (e.g. pyarrow types in pandas for pandas versions before they were supported)
  • pytest.raises: this raises, and we expect it to raise

We haven't been super-consistent about this internally. I think it would be good to:

  • document these standards in contributing.md
  • apply them as much as possible internally. This would require looking over the current test suite and making some judgement calls - feel free to ask on Discord about anything you're not sure about!
@luke396 luke396 self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants