Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the paths argument to discover() #122

Open
tlambert03 opened this issue Mar 12, 2022 · 0 comments
Open

Consider removing the paths argument to discover() #122

tlambert03 opened this issue Mar 12, 2022 · 0 comments

Comments

@tlambert03
Copy link
Collaborator

paths is there to allow discovery of plugins that are not in sys.path (by temporarily adding the specified paths to sys.path, just for the duration of discovery) ...
while it works for discovery, it's rather error prone later because of all of our usage of delayed imports and python_name. Unless the manifest somehow remembers that it came from somewhere outside of sys.path, it will break at import time, and I think it's a YAGNI feature anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant