Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest non-prerelease version of nameko-grpc depends on prerelease version of nameko #34

Open
jonblum opened this issue Nov 11, 2020 · 3 comments

Comments

@jonblum
Copy link

jonblum commented Nov 11, 2020

nameko-grpc 1.1.0, published to PyPI yesterday, requires nameko>=3.0.0-rc9 -- but a final version of Nameko 3 is not yet out. Users that do not allow prereleases in their dependency resolution will be unable to install nameko-grpc 1.1.0 and have to pin back to 1.0.1 -- unexpected for a minor version bump.

@mattbennett
Copy link
Member

@jonblum thank you for raising this issue!

My apologies -- I made some assumptions here that nameko-grpc was not being actively used. I should have published the latest version of nameko-grpc as a prerelease as well.

Are you using nameko-grpc and affected by this change?

@jonblum
Copy link
Author

jonblum commented Nov 12, 2020

Not yet in production, but we've been playing with it as a candidate for some of our services. We're no longer affected (only needed to pin our dependency from a permissive ~=1.0 to an explicit 1.0.1 for the time being) -- mostly just raised as an FYI or in case someone else's build broke and they were wondering why.

Thanks for all the work you've done on nameko-grpc!

@mattbennett
Copy link
Member

That is great to hear. nameko-grpc was initially an experiment and a prototype, but I'm pleased to say that it's finally going to see production use at Pace soon.

The two initial use-cases are:

  • Adding gRPC interfaces to existing microservices
  • As a client to Google Cloud Pub/Sub

The latter has thrown up some fun additional requirements:

  • Ability to use secure channels (landed in 1.1.0)
  • Need for better connection management

At this point I think it's probably best to leave 1.1.0 out there and keep this issue open. I'll make any additional releases either as pre-releases or to a private PyPI server. The next non pre-release of nameko-grpc can come after Nameko v3 is officially released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants