Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary on issues about PIT-CS #42

Open
zjkmxy opened this issue May 16, 2022 · 0 comments
Open

Summary on issues about PIT-CS #42

zjkmxy opened this issue May 16, 2022 · 0 comments
Assignees

Comments

@zjkmxy
Copy link
Member

zjkmxy commented May 16, 2022

Background: #38 #40

  • Performance is 25-50% worse after putting expiration in the same thread. Maybe the map deletion is slow.
    Possible bottleneck:
    delete(curNode.parent.children, curNode.component.String())
  • Till now PIT tokens are shown to be used in any tests. Not sure if it is YaNFD's problem.
  • pitTokenMap seems to be wrong:
    pitTokenMap map[uint32]*nameTreePitEntry
  • csMap does not look good. It assumes the hashes have no conflict.
    csMap map[uint64]*nameTreeCsEntry

    index := p.hashCsName(data.Name())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant